-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce parMap and deprecate parTraverseXXX #2863
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great to have Kover! Also... I need to add some tests in this PR! 😅 |
Draft until #2892 is merged. |
nomisRev
requested review from
i-walker,
serras,
franciscodr,
raulraja and
a team
January 20, 2023 10:21
serras
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
i-walker
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2788, introduces one of the signatures up for discussion in #2861.
This PR deprecates 46 APIs, and proposes to replace them by 6 favoring composition and simplicity. No functionality is lost.
parTraverse(N)
is proposed to be replaced byparMap
parTraverseEither(N)
is proposed to be replaced byeither
+parMap
parTraverseResult(N)
is proposed to be replaced byresult
+parMap
parTraverseValidated(N)
is proposed to be replaced byparMapOrAccumulate
in line with newly proposedmapOrAccumulate
.