Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce parMap and deprecate parTraverseXXX #2863

Merged
merged 11 commits into from
Jan 24, 2023
Merged

Conversation

nomisRev
Copy link
Member

@nomisRev nomisRev commented Dec 5, 2022

Closes #2788, introduces one of the signatures up for discussion in #2861.

This PR deprecates 46 APIs, and proposes to replace them by 6 favoring composition and simplicity. No functionality is lost.

  • parTraverse(N) is proposed to be replaced by parMap
  • parTraverseEither(N) is proposed to be replaced by either + parMap
  • parTraverseResult(N) is proposed to be replaced by result + parMap
  • parTraverseValidated(N) is proposed to be replaced by parMapOrAccumulate in line with newly proposed mapOrAccumulate.

@nomisRev nomisRev added the 1.2.0 Tickets belonging to 1.1.2 label Dec 9, 2022
@nomisRev nomisRev mentioned this pull request Dec 10, 2022
20 tasks
@nomisRev
Copy link
Member Author

Great to have Kover! Also... I need to add some tests in this PR! 😅

@nomisRev
Copy link
Member Author

Draft until #2892 is merged.

@nomisRev nomisRev marked this pull request as ready for review January 20, 2023 10:21
Copy link
Member

@serras serras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nomisRev nomisRev merged commit 65e5f65 into main Jan 24, 2023
@nomisRev nomisRev deleted the deprecate-partraverse branch January 24, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.2.0 Tickets belonging to 1.1.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate parTraverse in favor of parMap
3 participants